Add the ability to specify stdin to pass to a sub-command. #64
Conversation
| //! * `stdin: <string>`, text to be passed to the command's `stdin`. If the command exits without | ||
| //! having consumed all of `<string>`, an error will be raised. Note, though, that operating | ||
| //! system file buffers can mean that the command *appears* to have consumed all of `<string>` | ||
| //! without it actually having done so. |
There was a problem hiding this comment.
E.g. You have a bunch of newlines in your input string?
There was a problem hiding this comment.
The problem is even simpler than that: the OS and/or filesystem library might buffer input. So we might write to the pipe, see that the input has disappeared, and assume that it was read by the command; but the input might be in an intermediate buffer and the program can exit without ever actually having read it. I'm not aware that we can do anything about this.
There was a problem hiding this comment.
That matches my interpretation of the docstring.
There was a problem hiding this comment.
Ah I understand. Thanks!
|
Oops, forgot to add @vext01 to this. |
|
LGTM |
|
OK, so it sounds like we can merge? |
|
There's one outstanding comment from Jake, so I'll let him do the merge once he's happy. |
|
@vext01 I think we might want to, and be able to, go ahead with this one. Please have a look at my reply to Jake's question and see if you think it's been addressed or not. |
|
bors r+ |
|
Build succeeded: |
4: Use lang_tester r=vext01 a=ltratt Needs #3 and softdevteam/lang_tester#64 to be merged first (and a new release of lang_tester to be made). Co-authored-by: Laurence Tratt <laurie@tratt.net>
4: Use lang_tester r=vext01 a=ltratt Needs #3 and softdevteam/lang_tester#64 to be merged first (and a new release of lang_tester to be made). Co-authored-by: Laurence Tratt <laurie@tratt.net>
No description provided.