Use BDWGC finalization callback API #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this API, Boehm automatically invokes our finalization-thread code when there is finalization work to do (using GC_set_finalizer_notifier) and handles synchronization internally.
|
Dumb question: I was expecting to see some more code relating to the finalisation thread deleted? For example, can we now accidentally create two finalization threads? Or should I expect to see that in a PR to our BDWGC fork? |
jacob-hughes
added a commit
to jacob-hughes/bdwgc
that referenced
this pull request
Apr 25, 2025
This is now handled externally inside Alloy using the finalizer notifier API [1]. [1]: softdevteam/alloy#177
|
Good question! That has indeed been removed in Boehm here softdevteam/bdwgc#29 |
jacob-hughes
added a commit
to jacob-hughes/bdwgc
that referenced
this pull request
Apr 25, 2025
This is now handled externally inside Alloy using the finalizer notifier API [1]. [1]: softdevteam/alloy#177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this API, Boehm automatically invokes our finalization-thread code when there is finalization work to do (using GC_set_finalizer_notifier) and handles synchronization internally.