Fix asset loading to use script-relative paths for portability#2
Open
saifeemustafaq wants to merge 1 commit intosoftchris:mainfrom
Open
Fix asset loading to use script-relative paths for portability#2saifeemustafaq wants to merge 1 commit intosoftchris:mainfrom
saifeemustafaq wants to merge 1 commit intosoftchris:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix asset loading to use script-relative paths for portability
get_asset_path()to construct asset paths relative to the script's location.Problem
Previously, all asset files (images, sounds, etc.) were loaded using relative paths like "assets/player.png". This approach only works if the script is run from the directory containing the
assetsfolder. If the script is run from a different working directory, asset loading fails with aFileNotFoundError.Solution
This PR introduces a helper function,
get_asset_path(), which constructs asset paths relative to the location of the script (refactored.py). All asset loading calls have been updated to use this function. This ensures that assets are always loaded correctly, regardless of the current working directory from which the script is executed.Why this is important
Additional Notes
get_asset_path()function is documented to clarify its purpose.