Skip to content

Conversation

@khotyn
Copy link
Member

@khotyn khotyn commented Feb 20, 2021

Optimize imports of SOFATracer, such a lot of unused import.

close #428

Optimize imports of SOFATracer, such a lot of unused import.

close #428
@khotyn khotyn requested a review from glmapper February 20, 2021 14:30
@glmapper glmapper added this to the 3.1.1 milestone Feb 21, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #429 (c810a70) into master (bc58494) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
- Coverage     44.44%   44.43%   -0.02%     
  Complexity      219      219              
============================================
  Files           289      289              
  Lines          9539     9539              
  Branches        947      947              
============================================
- Hits           4240     4239       -1     
  Misses         4812     4812              
- Partials        487      488       +1     
Impacted Files Coverage Δ Complexity Δ
...sofa/tracer/plugins/datasource/MethodRegistry.java 98.00% <ø> (ø) 0.00 <0.00> (ø)
...ofa/tracer/plugins/datasource/SmartDataSource.java 62.85% <ø> (ø) 0.00 <0.00> (ø)
.../datasource/tracer/ConnectionTraceInterceptor.java 83.33% <ø> (ø) 0.00 <0.00> (ø)
...ource/tracer/DataSourceClientStatJsonReporter.java 94.11% <ø> (ø) 0.00 <0.00> (ø)
...tracer/plugins/dubbo26x/DubboSofaTracerFilter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tracer/plugins/dubbo27x/DubboSofaTracerFilter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...nt/interceptor/SofaTracerAsyncHttpInterceptor.java 88.88% <ø> (ø) 0.00 <0.00> (ø)
...pclient/interceptor/SofaTracerHttpInterceptor.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...cer/plugins/mongodb/SofaTracerCommandListener.java 7.93% <ø> (ø) 1.00 <0.00> (ø)
...s/rabbitmq/aspect/SofaTracerSendMessageAspect.java 10.00% <ø> (ø) 1.00 <0.00> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc58494...c810a70. Read the comment docs.

@khotyn khotyn marked this pull request as ready for review April 14, 2021 14:19
@khotyn
Copy link
Member Author

khotyn commented Apr 14, 2021

@glmapper Pls review this pull request, just remove some unused import.

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glmapper glmapper merged commit babc173 into master Apr 15, 2021
@glmapper glmapper deleted the optimize_import branch April 15, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize imports

3 participants