Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try function programming #252

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Try function programming #252

merged 4 commits into from
Oct 31, 2018

Conversation

QilongZhang
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 579

  • 52 of 62 (83.87%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.2%) to 69.193%
Changes Missing Coverage Covered Lines Changed/Added Lines %
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/utils/BinaryOperators.java 1 2 50.0%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/AfterReadinessCheckCallbackProcessor.java 15 17 88.24%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthIndicatorProcessor.java 19 22 86.36%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 2 0.0%
Totals Coverage Status
Change from base Build 575: -1.2%
Covered Lines: 1397
Relevant Lines: 2019
💛 - Coveralls

@QilongZhang QilongZhang deleted the try_function_programming branch October 30, 2018 12:25
@QilongZhang QilongZhang restored the try_function_programming branch October 30, 2018 12:25
@QilongZhang QilongZhang reopened this Oct 30, 2018
straybirdzls
straybirdzls reviewed Oct 31, 2018
View reviewed changes
...ain/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java Outdated
}
.load(SofaBootTagNameSupport.class);
StreamSupport.stream(serviceLoaderSofaBoot.spliterator(), false)
.forEach(this::registerTagParser);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use serviceLoaderSofaBoot.forEach(it -> registerTagParser(it)) here? I think it's more clear and simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@straybirdzls fixed.

@straybirdzls straybirdzls merged commit 48cda19 into sofastack:3.0.x Oct 31, 2018
@QilongZhang QilongZhang added this to the 3.0.0 milestone Nov 6, 2018
@QilongZhang QilongZhang deleted the try_function_programming branch December 26, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straybirdzls straybirdzls straybirdzls left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QilongZhang @coveralls @straybirdzls