Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize auto-configuration. #221

Merged
merged 7 commits into from
Sep 20, 2018
Merged

Optimize auto-configuration. #221

merged 7 commits into from
Sep 20, 2018

Conversation

QilongZhang
Copy link
Contributor

fix #220

@QilongZhang QilongZhang added the enhancement New feature or request label Sep 17, 2018
@QilongZhang QilongZhang added this to the 2.5.0 milestone Sep 17, 2018
@coveralls
Copy link

coveralls commented Sep 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 503

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.274%
Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/SofaRuntimeContextAwareProcessor.java 6 7 85.71%
Totals Coverage Status
Change from base Build 502: 0.05%
Covered Lines: 1578
Relevant Lines: 2214
💛 - Coveralls

@caojie09 caojie09 merged commit 8765bad into sofastack:master Sep 20, 2018
khotyn
khotyn reviewed Sep 21, 2018
View reviewed changes
...src/main/java/com/alipay/sofa/runtime/spring/configuration/SofaRuntimeAutoConfiguration.java
@@ -100,23 +105,28 @@ public SofaRuntimeContext sofaRuntimeContext(@Value("${"
}

@Bean
public ServiceAnnotationBeanPostProcessor serviceAnnotationBeanPostProcessor(BindingAdapterFactory bindingAdapterFactory,
BindingConverterFactory bindingConverterFactory) {
public static ServiceAnnotationBeanPostProcessor serviceAnnotationBeanPostProcessor(BindingAdapterFactory bindingAdapterFactory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the method to a static method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khotyn , By marking this method as static, it can be invoked without causing instantiation of its @configuration class

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, seems it's hack way. It there some more straightforward way to solve the problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khotyn it a recommended way，you can see the doc of @Bean.

@QilongZhang QilongZhang deleted the optimize_configuration branch September 21, 2018 02:19
@QilongZhang QilongZhang mentioned this pull request Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khotyn khotyn khotyn left review comments

@caojie09 caojie09 caojie09 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Optimize SOFABoot Configuration to avoid that some class cannot be applied bfpp.
4 participants
@QilongZhang @coveralls @khotyn @caojie09