Manager starter and third-lib version. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofaboot-dependencies/pom.xml
Outdated
| <groupId>org.slf4j</groupId> | ||
| <artifactId>log4j-over-slf4j</artifactId> | ||
| <version>${slf4j.api.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
这两个在 spring-boot-dependencies 中已经管控了
There was a problem hiding this comment.
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>${guava.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
这些改完之后 rpc 也记得配合改下 ，之前这些组件应该都是在 rpc 中管理的
There was a problem hiding this comment.
这些组件在商业版也管理了，所以使用商业版时，都以这些版本为效。 rpc 那边最好是配置相同版本，不过可以不强制要求。
straybirdzls
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.