Repository navigation
Conversation
pybind11 3.1.0 runs keep_alive's postcall on the try-next-overload sentinel, so bindings declared with keep_alive<0, N> -- Node.addObject -- segfault when called with arguments that match no overload instead of raising TypeError. pixi.lock currently resolves 3.1.0 for every environment. Fixed upstream by pybind/pybind11#6183. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Generated with pixi 0.67.2 to keep the lock file at format v6. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Enable the python-newest feature that pixi.toml already sketched and add a standard-python-newest environment that uses it, so CI can build and test SofaPython3 against 3.14 by passing that preset. Ubuntu 26.04 LTS defaults to python 3.14. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Generated with pixi 0.67.2 to keep the lock file at format v6. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Hello ! Thank you for your commit, but this PR collides with the current work on our CI infrastructure. Bumping the version to python 3.14 is indeed wanted, but first the builder of the other os should follow. It will soon be the case and we will be able to merge this at that moment. |
bakpaul
added
pr: status to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #6348 (pybind11 < 3.1); the first two commits here are that PR's and will drop out once it is merged. The change in this PR is the last two commits.
pixi.tomlalready sketches apython-newestfeature (python = "3.14.*") for testing the upper bound of supported Python versions. This enables it and adds astandard-python-newestenvironment (thestandardenvironment withpython-newestin place ofpython-supported), so the pixi CI can build and test SofaPython3 on 3.14 by passing that preset. Ubuntu 26.04 LTS ships Python 3.14 as its default.The
pixi.lockchange only adds the new environment (+806 lines, nothing else moves); it was generated with pixi 0.67.2 so the lock file stays at format v6.Tested on linux-64 from the committed lock (
pixi install --locked -e standard-python-newest, then thestandardpreset with SofaPython3 and its tests enabled):Bindings.Sofa.TestsBindings.Modules.Testsscipy, which the CI adds frompython_extra_dependencies.txt)Bindings.SofaRuntime.TestsBindings.SofaTypes.TestsNo SofaPython3 source changes are needed for 3.14. For reference, the released 26.06 SofaPython3 + BeamAdapter also build and run on 3.14 on linux-64, win-64 and osx-64 through conda-forge (conda-forge/sofa-python3-feedstock#4).
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if