[FileSystem] Avoid race condition when two scenes try to create config dir in same time#5752
Merged
epernod merged 5 commits intosofa-framework:masterfrom Nov 14, 2025
Conversation
Contributor
Author
|
[ci-build][with-all-tests] |
…scene_tests_in_parallel
Contributor
Author
|
[ci-build][with-all-tests] |
…scene_tests_in_parallel
hugtalbot
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race conditions appeared when we launch scene tests in parallel on ubuntu docker images. Because the folder never exists at the beginning, when launching the scene tests in parallel, all the first scenes launched by workers tried to create it which throwed theses errors:
Fortunately (or not), jenkins doesn't count errors but only crashes for scene tests. Which not the case for the new CI, so I need to get this fixed. The fix is simple: if mkdir returns a "file already exists' when trying mkdir, then we're all good, this will only happen in the case of race condition, otherwise mkdir wouldn't have been launched in the first place.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if