Skip to content

Conversation

@olivier-roussel
Copy link
Contributor

This PR fixes a requirement of conda-forge/staged-recipes#23085 for the SOFA conda package on conda-forge.
It is required that header-only embedded libraries have their license in a separate file, that can be listed then in the conda package recipe.
This PR adds a missing license file for json nlohmann library (MIT) and homogenize the license file name for the two others SOFA header-only embedded libraries (difflib and stb, both also on MIT license).
Cxxopts, which the last header-only embedded library in SOFA, will be treated separately in another PR to handle the code fetch case through cmake FetchContent.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 31, 2023
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but I guess this is up to @hugtalbot or @bakpaul to merge it 🧐

@olivier-roussel olivier-roussel changed the title Fix headeronly extlibs licenses [all] Fix headeronly extlibs licenses Oct 31, 2023
@bakpaul
Copy link
Contributor

bakpaul commented Nov 2, 2023

Why the '.MIT' for the license file ? Is it required by conda ? Because I can see that being cumbersome for windows user to have to define an opening rule for each license type (eventhough I know no one read such a file...). Not very important in fact, but may be just having a '.txt' or nothing at all (as in the most cases) me be better ?

@olivier-roussel
Copy link
Contributor Author

Three reasons:

  • It was named as-it in the json nlohmann repository, so I basically just picked their license file
  • It is convenient (but not required by conda-forge) as all license files must be listed explicitly in the conda package recipe, so basically you know which kind of license you have with your package and all its embedded libs without having to dig each file
  • I chose to rename the two other license files (diff lib and stb) accordingly, as they are both also MIT so looks a good idea to be homogeneous here (and in any case there was a typo in the initial license names, it was spelled the french way)

@bakpaul bakpaul merged commit ddfe195 into sofa-framework:master Nov 2, 2023
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants