Use PyMem_RawFree when resetting PythonEnvironmentData #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Awesome debug @fredroy |
hugtalbot
approved these changes
Sep 9, 2024
bakpaul
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runSofa + SofaPython3 is crashing when quitting (since I dont know when) ?
After investigation, PyMem_Free is called without GIL, which is illegal.
python/cpython#105690
I guess this behavior started when clearing the env when unloading (#432), plus python 3.12
Instead we must call
PyMem_RawFreewhich allows us to delete non-obj (our case) without the gil.PS1: the whole PySys_SetArgvEx stuff is deprecated and will need a rewrite.
PS2: I am skeptical about the needs to store the m_argv, etc 🤔