Add cleanup to core and ensure that the cleanup happens in runSofa #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
reviewed
Jul 15, 2024
|
|
||
| void clearCache() | ||
| { | ||
| msg_info("SofaPython3") << "Clearing Sofa.Core cache..."; |
Contributor
There was a problem hiding this comment.
Why Sofa.Core whereas this code is not in Sofa.Core?
Contributor
Author
There was a problem hiding this comment.
Yes, but this cache is only used in Sofa.Core, in the data binding.
hugtalbot
added
pr: status ready
pr: status to review
and removed
pr: status to review
pr: status ready
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Release" method was never called when running python scene through runSofa, leading to non-correct cleanup of the python interpreter.
This PR adds the cleanup callback and ensure that the data cache is deleted before the interpreter (in Sofa.Core)