[consensus] Counter for consensus messages by type (MystenLabs#8759)

soerenwa · Mar 1, 2023 · 91b6e22 · 91b6e22
1 parent fa726b4
commit 91b6e22
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/crates/sui-core/src/authority.rs b/crates/sui-core/src/authority.rs
@@ -191,6 +191,7 @@ pub struct AuthorityMetrics {
     /// Consensus handler metrics
     pub consensus_handler_processed_batches: IntCounter,
     pub consensus_handler_processed_bytes: IntCounter,
+    pub consensus_handler_processed: IntCounterVec,
 }
 
 // Override default Prom buckets for positive numbers in 0-50k range
@@ -383,6 +384,8 @@ impl AuthorityMetrics {
                 "Number of bytes processed by consensus_handler",
                 registry
             ).unwrap(),
+            consensus_handler_processed: register_int_counter_vec_with_registry!("consensus_handler_processed", "Number of transactions processed by consensus handler", &["class"], registry)
+                .unwrap()
         }
     }
 }

diff --git a/crates/sui-core/src/consensus_handler.rs b/crates/sui-core/src/consensus_handler.rs
@@ -17,8 +17,8 @@ use std::hash::{Hash, Hasher};
 use std::sync::{Arc, Mutex};
 use sui_types::base_types::{AuthorityName, EpochId, TransactionDigest};
 use sui_types::messages::{
-    ConsensusTransaction, ConsensusTransactionKey, VerifiedExecutableTransaction,
-    VerifiedTransaction,
+    ConsensusTransaction, ConsensusTransactionKey, ConsensusTransactionKind,
+    VerifiedExecutableTransaction, VerifiedTransaction,
 };
 use sui_types::storage::ParentSync;
 use tracing::{debug, error, instrument};
@@ -136,6 +136,10 @@ impl<T: ParentSync + Send + Sync> ExecutionState for ConsensusHandler<T> {
                             continue;
                         }
                     };
+                    self.metrics
+                        .consensus_handler_processed
+                        .with_label_values(&[classify(&transaction)])
+                        .inc();
                     let transaction = SequencedConsensusTransactionKind::External(transaction);
                     transactions.push((serialized_transaction, transaction, output_cert.clone()));
                 }
@@ -226,6 +230,21 @@ impl<T> ConsensusHandler<T> {
     }
 }
 
+fn classify(transaction: &ConsensusTransaction) -> &'static str {
+    match &transaction.kind {
+        ConsensusTransactionKind::UserTransaction(certificate) => {
+            if certificate.contains_shared_object() {
+                "shared_certificate"
+            } else {
+                "owned_certificate"
+            }
+        }
+        ConsensusTransactionKind::CheckpointSignature(_) => "checkpoint_signature",
+        ConsensusTransactionKind::EndOfPublish(_) => "end_of_publish",
+        ConsensusTransactionKind::CapabilityNotification(_) => "capability_notification",
+    }
+}
+
 pub struct SequencedConsensusTransaction {
     pub certificate: Arc<narwhal_types::Certificate>,
     pub consensus_index: ExecutionIndicesWithHash,