Skip to content

Use globalThis instead of global #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mafintosh merged 2 commits into from
Nov 2, 2021
Merged

Use globalThis instead of global #61

mafintosh merged 2 commits into from
Nov 2, 2021

Conversation

@kasperisager
Copy link
Contributor

@kasperisager kasperisager commented Nov 2, 2021

standard has been updated to v15 which has support for the globalThis variable.

@kasperisager kasperisager mentioned this pull request Nov 2, 2021
Open
22 tasks
@mafintosh
Copy link
Member

mafintosh commented Nov 2, 2021

Nice, is globalThis a browser thing?

@kasperisager
Copy link
Contributor Author

kasperisager commented Nov 2, 2021

It's a standardized way of accessing the global object, i.e. window in browsers and global in Node.js: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis

@mafintosh mafintosh merged commit 87ff2a5 into sodium-friends:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasperisager @mafintosh