BREAKING: Rename '_ready' suffix to '_wasm_ready' #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking through each of the extra methods exposed by this module I noticed lots of 'wasm' mentions, but since this method doesn't mention wasm it wasn't clear to me why this extra method was being exposed. This commit is a breaking change that renames crypto_generichash_ready to crypto_generichash_wasm_ready, which feels more clear to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through each of the extra methods exposed by this module I
noticed lots of 'wasm' mentions, but since this method doesn't mention
wasm it wasn't clear to me why this extra method was being exposed.
This commit is a breaking change that renames crypto_generichash_ready
to crypto_generichash_wasm_ready, which feels more clear to me.