Skip to content

added custom loader hook to resolve /opt/nodejs/ modules #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2020
Merged

added custom loader hook to resolve /opt/nodejs/ modules #1

merged 1 commit into from
Dec 13, 2020

Conversation

brandonryan
Copy link

@brandonryan brandonryan commented Dec 13, 2020

There is still a few things that could be done to make this better.

  1. add resolution for /opt/node${NODE_MAJOR}
  2. add resolution for /var/runtime
  3. add a flag to use this feature as opposed to always on (but i really think it should just be always there personally)
  4. we should probably resolve modules the normal way and then try other directories later, but I wanted to give the user an error that makes sense, so I'm doing that last.

I have to go now, but ill add 1, 2, and 4 later

@sodiray sodiray merged commit fd8b0a9 into sodiray:node-v14 Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants