Upload/events #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated CHANGELOG.md to document the fix for folder counts not updating in the sidebar after rule-based folder assignment on upload. - Bumped version in package.json, readme.txt, and vmfa-rules-engine.php to 1.1.2. - Added media upload script (build/media-upload.js) to refresh media library after uploads. - Created media upload asset file (build/media-upload.asset.php) for script dependencies. - Integrated media upload handler in Plugin.php to enqueue the new script on the media library page. - Enhanced RuleEvaluator.php to update term count and clean object term cache immediately after folder assignment. - Updated tests in RuleEvaluatorTest.php to ensure new functionality is covered. - Added parent plugin integration proposal documentation for better add-on interaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where folder counts in the sidebar were not updating correctly after rule-based folder assignment during media uploads. The update ensures that the UI accurately reflects folder assignments immediately after uploads, improving user experience and integration reliability. Additionally, it introduces a dedicated upload handler script, updates documentation, and bumps the plugin version.
Media upload and folder refresh improvements:
media-upload.jsscript that hooks into the WordPress media uploader to explicitly callvmfRefreshFolders()and refresh the sidebar counts after rule-based folder assignment, using a debounce to batch updates.enqueue_media_upload_scriptmethod inPlugin.php. [1] [2] [3] [4]Documentation and versioning:
docs/parent-plugin-integration-proposal.mdto guide future enhancements and add-on compatibility.