Fix/best practices audit

CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.3.1] - 2025-06-25
+
+### Fixed
+
+- Added `defined( 'ABSPATH' ) || exit` guards to all PHP source files
+
+### Added
+
+- `uninstall.php` for clean plugin removal
+
 ## [1.3.0] - 2026-02-07
 
 ### Fixed

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "vmfa-rules-engine",
-	"version": "1.3.0",
+	"version": "1.3.1",
 	"description": "Rule-based automatic folder assignment for media uploads",
 	"author": "Per Soderlind",
 	"license": "GPL-2.0-or-later",

readme.txt

@@ -5,7 +5,7 @@ Tags: media library, virtual folders, automation, rules engine, media organizati
 Requires at least: 6.8
 Tested up to: 6.8
 Requires PHP: 8.3
-Stable tag: 1.3.0
+Stable tag: 1.3.1
 License: GPLv2 or later
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
 
@@ -108,6 +108,10 @@ Each imported file will be evaluated against your rules and assigned to the matc
 
 == Changelog ==
 
+= 1.3.1 =
+* Fixed: Added ABSPATH guards to all PHP source files
+* Added: uninstall.php for clean plugin removal
+
 = 1.3.0 =
 * Fixed: Changed `vmfa_rules_engine_skip_if_assigned` filter default from `false` to `true`
 * Fixed: Rules Engine now respects folder assignments made by Editorial Workflow by default

src/php/Conditions/AuthorMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches upload author (user ID).
  */

src/php/Conditions/DimensionsMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches image dimensions (width/height).
  */

src/php/Conditions/ExifCameraMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches EXIF camera model.
  */

src/php/Conditions/ExifDateMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches EXIF date taken.
  */

src/php/Conditions/FileSizeMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches file size.
  */

src/php/Conditions/FilenameRegexMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches filename against a regular expression.
  */

src/php/Conditions/IptcKeywordsMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches IPTC keywords embedded in the image.
  */

src/php/Conditions/MatcherInterface.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Interface for condition matchers.
  */

src/php/Conditions/MimeTypeMatcher.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Conditions;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Matches file MIME type.
  */

src/php/Plugin.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine;
 
+defined( 'ABSPATH' ) || exit;
+
 use VmfaRulesEngine\Admin\SettingsPage;
 use VmfaRulesEngine\REST\RulesController;
 use VmfaRulesEngine\Services\RuleEvaluator;

src/php/REST/RulesController.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\REST;
 
+defined( 'ABSPATH' ) || exit;
+
 use VmfaRulesEngine\Repository\RuleRepository;
 use VmfaRulesEngine\Services\BatchProcessor;
 use WP_REST_Controller;

src/php/Repository/RuleRepository.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Repository;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Handles CRUD operations for rules stored in WordPress options.
  */

src/php/Services/BatchProcessor.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Services;
 
+defined( 'ABSPATH' ) || exit;
+
 /**
  * Handles batch rule application to existing media library.
  */

src/php/Services/RuleEvaluator.php

@@ -7,6 +7,8 @@
 
 namespace VmfaRulesEngine\Services;
 
+defined( 'ABSPATH' ) || exit;
+
 use VmfaRulesEngine\Repository\RuleRepository;
 use VmfaRulesEngine\Conditions\MatcherInterface;
 use VmfaRulesEngine\Conditions\FilenameRegexMatcher;

src/php/Update/GitHubPluginUpdater.php

@@ -3,6 +3,8 @@
 
 namespace VmfaRulesEngine\Update;
 
+defined( 'ABSPATH' ) || exit;
+
 use YahnisElsts\PluginUpdateChecker\v5\PucFactory;
 
 /**
@@ -11,7 +13,7 @@
  * A reusable class for handling WordPress plugin updates from GitHub repositories
  * using the plugin-update-checker library.
  * 
- * @package ContentPoll\Update
+ * @package VmfaRulesEngine\Update
  * @version 1.0.0
  * @author Per Soderlind
  * @license GPL-2.0+

uninstall.php

@@ -0,0 +1,19 @@
+<?php
+/**
+ * Uninstall handler for Virtual Media Folders - Rules Engine.
+ *
+ * Fired when the plugin is deleted via the WordPress admin.
+ *
+ * @package VmfaRulesEngine
+ */
+
+// Exit if not called by WordPress.
+if ( ! defined( 'WP_UNINSTALL_PLUGIN' ) ) {
+	exit;
+}
+
+// Delete plugin options.
+delete_option( 'vmfa_rules_engine_rules' );
+
+// Delete transients.
+delete_transient( 'vmfa_rules_engine_preview_cache' );

vmfa-rules-engine.php

@@ -3,7 +3,7 @@
  * Plugin Name: Virtual Media Folders - Rules Engine
  * Plugin URI: https://github.com/soderlind/vmfa-rules-engine
  * Description: Rule-based automatic folder assignment for media uploads. Add-on for Virtual Media Folders.
- * Version: 1.3.0
+ * Version: 1.3.1
  * Author: Per Soderlind
  * Author URI: https://soderlind.no
  * License: GPL-2.0-or-later
@@ -20,7 +20,7 @@
 defined( 'ABSPATH' ) || exit;
 
 // Plugin constants.
-define( 'VMFA_RULES_ENGINE_VERSION', '1.3.0' );
+define( 'VMFA_RULES_ENGINE_VERSION', '1.3.1' );
 define( 'VMFA_RULES_ENGINE_FILE', __FILE__ );
 define( 'VMFA_RULES_ENGINE_PATH', plugin_dir_path( __FILE__ ) );
 define( 'VMFA_RULES_ENGINE_URL', plugin_dir_url( __FILE__ ) );