Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller code after decoupling #1

Merged
merged 7 commits into from
Apr 10, 2020

Conversation

PravinRanjan10
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
This project only contains Controller related code.

All the apiserver layer files, codes are removed

All the dock layer files, codes are removed

Directory path is changed:
github.com/opensds/opensds
to
github.com/sodafoundation/controller

Variable names and OpenSDS author part is not changed.

Release note:

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #1 into master will increase coverage by 6.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   34.72%   41.40%   +6.67%     
==========================================
  Files          97       33      -64     
  Lines       17665     5598   -12067     
==========================================
- Hits         6135     2318    -3817     
+ Misses      10651     2819    -7832     
+ Partials      879      461     -418     
Impacted Files Coverage Δ
client/auth.go 0.00% <ø> (ø)
client/dock.go 50.00% <ø> (ø)
client/fake.go 47.00% <ø> (ø)
client/fileshare.go 73.17% <ø> (ø)
client/host.go 68.08% <ø> (ø)
client/pool.go 50.00% <ø> (ø)
client/profile.go 61.97% <ø> (ø)
client/receiver.go 0.00% <ø> (ø)
client/replication.go 51.61% <ø> (ø)
client/version.go 52.94% <ø> (ø)
... and 20 more

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: Many files change, as it is for decoupling single project to multiple projects for maintenance, modularity, and scalability

@skdwriting skdwriting merged commit 960e6ef into sodafoundation:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants