Add fujitsu ETERNUS DX driver#935
Merged
xing-yang merged 2 commits intoJul 1, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #935 +/- ##
=============================================
+ Coverage 31.2% 33.4% +2.2%
=============================================
Files 82 85 +3
Lines 15216 16325 +1109
=============================================
+ Hits 4748 5454 +706
- Misses 9764 10091 +327
- Partials 704 780 +76
|
xing-yang
reviewed
Jun 28, 2019
xing-yang
left a comment
xing-yang
left a comment
Collaborator
There was a problem hiding this comment.
@hirokikmr Thanks for contributing the Fujitsu driver! Can you please fill the "release note" section at the top of the PR?
leonwanghui
requested changes
Jun 28, 2019
leonwanghui
left a comment
leonwanghui
left a comment
Collaborator
There was a problem hiding this comment.
After developing the code, please use gofmt or goimports to format the code style.
Collaborator
|
@xing-yang @wisererik PTAL, thanks! |
leonwanghui
added
CAPRI
kumarashit
reviewed
Jul 1, 2019
| } | ||
|
|
||
| // ParseIPv4 : convert hex string to ip address | ||
| func ParseIPv4(ip string) string { |
Collaborator
There was a problem hiding this comment.
To me these functions appear to be common which can be used by other driver developers too. @leonwanghui Can we put this in driver common and then other can also re-use it
| hostLunID = strconv.Itoa(i) | ||
| break | ||
| } | ||
| hostLunID = strconv.Itoa(i + 1) |
Collaborator
There was a problem hiding this comment.
One question: Will there be a synchronization issue while generating the LunID?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding fujitsu ETERNUS DX driver.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
This driver has below functions for now.
Release note: