remove distutils in order to support python 3.12 #2439
Conversation
|
vebjorre
changed the title
| def strtobool(val: str) -> bool: | ||
| return val.lower() in ("yes", "y", "true", "t", "1") | ||
|
|
||
|
|
There was a problem hiding this comment.
Hello @vebjorre , thanks very much for this contribution! We'd like to request two small edits after which we'd be happy to merge and release this.
- It looks like
"on"should be in the tuple - The original
strtoboolimplementation throws a ValueError if you pass in an invalid value, we'd like to keep that behavior
If you could make those edits then we'll move this forward, thanks again!
There was a problem hiding this comment.
Thank you, that's perfect!
I'm seeing a failure in our CI, I think it's probably spurious but I'll have to investigate that before we can merge. I'll investigate next week and update you.
There was a problem hiding this comment.
I'll need to make a small change to our workflow file to update some credentials, should be able to get to it this week, thanks for your patience.
There was a problem hiding this comment.
I had to move some other things ahead of this in my to-do list, I will come back to this as soon as I can, and I'll keep you updated. Thank you
…values to include "on"/"off" variants.
|
|
paulteehan
left a comment
paulteehan
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
3 participants
Finishing the work of @akx in #2144, removing any use of distutils in order to support python>=3.12.
Fixes #2091