Skip to content

Fix handling of optional compression. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix handling of optional compression. #17

merged 1 commit into from
Oct 5, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Oct 5, 2023

Safari sometimes skips permessage-deflate using the frame flags as is appropriate, but it was not handled correctly in Inflate#unpack_frames. The flag check was always true regardless of the flag not being set due to a bug in the code.

We also fix the handling of the compress: option.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix merged commit e6a8fe8 into main Oct 5, 2023
@ioquatix ioquatix deleted the fix-flags-check branch October 5, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant