Fix header parsing, allowing for \t characters between VCHAR. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-williams-shopify
force-pushed
the
user-agent-header-parsing
branch
from
d093d22 to
cedb025
Compare
ioquatix
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified a specific header format which included tab characters, which was rejected by the existing header parser. This change aligns the header
FIELD_VALUEto more closely align with https://www.rfc-editor.org/rfc/rfc7230.html#section-3.2.This also prevents headers with non-printable ASCII characters (decimal value 127+), as per the above RFC. This might be considered a breaking change as previously these values were allowed.
Types of Changes
Contribution