Bail out before trying to extend Backend::Interface.

socketry · Aug 25, 2024 · 5e56726 · 5e56726
1 parent 8d60b7a
commit 5e56726
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/metrics/backend.rb b/lib/metrics/backend.rb
@@ -14,9 +14,13 @@ def self.require_backend(env = ENV)
 					require(backend)
 				rescue LoadError => error
 					::Console::Event::Failure.for(error).emit(self, "Unable to load metrics backend!", backend: backend, severity: :warn)
+
+					return false
 				end
 
 				Metrics.extend(Backend::Interface)
+
+				return true
 			end
 		end
 	end

diff --git a/test/metrics/backend.rb b/test/metrics/backend.rb
@@ -13,7 +13,9 @@
 		include_context Sus::Fixtures::Console::CapturedLogger
 
 		it "logs a warning if backend cannot be loaded" do
-			subject.require_backend({"METRICS_BACKEND" => "metrics/backend/missing"})
+			expect(
+				subject.require_backend({"METRICS_BACKEND" => "metrics/backend/missing"})
+			).to be == false
 
 			expect_console.to have_logged(
 				severity: be == :warn,