Better handling of waiter invalidation in PriorityQueue.
#419
+105
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-williams-shopify
force-pushed
the
priority-queue-waiter-invalidation
branch
from
3450a9c to
98c4235
Compare
ioquatix
changed the title
PriorityQueue.
samuel-williams-shopify
force-pushed
the
priority-queue-waiter-invalidation
branch
from
98c4235 to
b192abd
Compare
Add waiter invalidation to prevent abandoned waiters from accumulating in the @waiting heap when exceptions occur during dequeue operations. - Add Waiter#invalidate! method that nullifies fiber and condition. - Add Waiter#valid? method to check if waiter is still usable. - Add ensure block in dequeue to invalidate waiters on exceptions.
samuel-williams-shopify
force-pushed
the
priority-queue-waiter-invalidation
branch
from
b192abd to
7de6caf
Compare
ioquatix
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add waiter invalidation to prevent abandoned waiters from accumulating in the
@waitingheap when exceptions occur during dequeue operations.Waiter#invalidate!method that nullifies fiber and condition.Waiter#valid?method to check if waiter is still usable.Types of Changes
Contribution