Fix race between stop and task exiting. #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
async-barrier-stop-race
branch
2 times, most recently
from
9303110 to
314d082
Compare
ioquatix
force-pushed
the
async-barrier-stop-race
branch
from
314d082 to
edf01b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in
Async::Barrierthat occurred whenbarrier.stopis called while tasks are still finishing, particularly those withensureblocks. Whenstopis called, it closes the internal queue used for task completion signaling. However, tasks that are still executing their cleanup code (inensureblocks) would attempt to signal their completion to this now-closed queue, resulting in aQueue::ClosedError.Types of Changes
Contribution