Skip to content

Pass in the options when creating a new Async::Redis::ClusterClient? #59

Closed
@travisbell

Description

@travisbell

Hey Samuel,

I noticed a discrepancy between the regular Async::Redis::Client and the Async::Redis::ClusterClient and wasn't sure if it was by design or simply an oversight.

def initialize(endpoints, **options)
@endpoints = endpoints
@shards = nil
end

The standard Async::Redis::Client lets you pass in some options (like limit for example) while the Async::Redis::ClusterClient takes the param but doesn't do anything with it. Is that by design or an oversight? I can see with the Async::Redis::ClusterClient, it's a bit more involved as those options need to make their way into reload_cluster! which is different than the regular call to make_pool.

Thanks as always!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions