Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jun 8, 2021

Description

CI fails, this PR attempts to make the build fail instead of error out. JRuby-related.

This fixes #45.

  • JRuby: Avoid warning "Script coverage disabled: unknown event: script_compiled"
  • JRuby: Enable ObjectSpace.
  • JRuby: Skip a test to see if it was the only slow one. (It wasn't.)

Types of Changes

  • Maintenance.

Testing

I ran the CI, and noted that it now runs-but-fails, as opposed to erroring out.

    ObjectSpace is disabled; each_object will only work with Class, pass -X+O to enable

Also: Quote 3.0 to avoid YAML Float-to-String conversion loss
@olleolleolle olleolleolle marked this pull request as ready for review June 8, 2021 13:35
This would add code coverage information.
@olleolleolle olleolleolle force-pushed the avoid-bake-modernize-in-tests branch from 9544e90 to e4cdd84 Compare June 8, 2021 13:43
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jun 8, 2021

Async::Container::Threaded
  behaves like Async::IO::SharedEndpoint
Error: The action has timed out.

This test consistently times out.

RSpec.describe Async::Container::Threaded, if: RUBY_PLATFORM !~ /darwin/ do
	it_behaves_like Async::IO::SharedEndpoint, described_class
end

Perhaps we can skip on JRuby, too?

Update: skipping on JRuby made another test be "where it times out":

Async::IO::Socket
  basic udp server
Error: The action has timed out.

@ioquatix ioquatix merged commit bee07c4 into master Jun 8, 2021
@ioquatix ioquatix deleted the avoid-bake-modernize-in-tests branch June 8, 2021 21:03
@ioquatix
Copy link
Member

ioquatix commented Jun 8, 2021

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: build fail on jruby re: bake-modernize dep "rugged"

3 participants