This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Use native I/O when the scheduler is supported. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
native-io
branch
2 times, most recently
from
4ecc047 to
ee8f01a
Compare
ioquatix
force-pushed
the
native-io
branch
3 times, most recently
from
91af87c to
01ad44c
Compare
ioquatix
force-pushed
the
native-io
branch
3 times, most recently
from
ae40492 to
255fafb
Compare
|
Seems like io-event already dropped support for Ruby 3.0. So this can be merged? |
|
I'm still considering the options of deprecating this entire gem vs trying to update it. |
|
That's good to know. Would |
|
Just FYI: The wrapper works fine, but inherits from |
|
Last FYI: I was able to refactor the code so it doesn't need Thanks for your support. |
|
This is non longer relevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the implementation to delegate directly to native I/O where possible. However, there is one bug in the Ruby 3.0.0 (& 3.0.1) release which prevent its use (https://bugs.ruby-lang.org/issues/17527). This has been fixed and should be released in Ruby 3.1 and hopefully back ported to 3.0 eventually.
Types of Changes
Testing