Skip to content

Fix memory leak in PerThreadPersistentClients #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix memory leak in PerThreadPersistentClients #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/async/http/faraday/clients.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
require "async/http/client"
require "async/http/proxy"

::Thread.attr_accessor :async_http_faraday_per_thread_persistent_client

module Async
module HTTP
module Faraday
Expand Down Expand Up @@ -177,10 +179,10 @@ def with_proxied_client(proxy_endpoint, endpoint, &block)
# This will close all clients associated with all threads.
def close
Thread.list.each do |thread|
if clients = thread[@key]
if clients = thread.async_http_faraday_per_thread_persistent_client
clients.close

thread[@key] = nil
thread.async_http_faraday_per_thread_persistent_client = nil
end
end
end
Expand All @@ -192,9 +194,7 @@ def make_clients
end

def clients
thread = Thread.current

return thread.thread_variable_get(@key) || thread.thread_variable_set(@key, make_clients)
Thread.current.async_http_faraday_per_thread_persistent_client ||= make_clients
end
end
end
Expand Down