Skip to content

Move error handling to ensure loop continues after child process management #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Move error handling to ensure loop continues after child process management #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/async/container/generic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,13 @@ def spawn(name: nil, restart: false, key: nil, health_check_timeout: nil, &block
age_clock&.reset!
end
end
rescue => error
Console.error(self, "Error during child process management!", exception: error, running: @running)
ensure
delete(key, child)
end

if status.success?
if status&.success?
Console.info(self, "Child exited successfully.", status: status, running: @running)
else
@statistics.failure!
Expand All @@ -220,9 +222,6 @@ def spawn(name: nil, restart: false, key: nil, health_check_timeout: nil, &block
break
end
end
rescue => error
Console.error(self, "Failure during child process management!", exception: error, running: @running)
raise
ensure
Console.info(self, "Child process management loop exited.", running: @running)
end.resume
Expand Down
Loading