docs: fix conjunction with fastify example #5057
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Right now the readme example directly uses
app.io
in the conjunction with fastify example butio
is undefined while the server (app) is not readyNew behavior
Now app.io is accessed after the server (app) is ready so it is defined
Other information (e.g. related issues)
I was using it for the first time and got confused if I installed something wrong, then after diving into the detailed docs I understood what I was doing wrong.
Couldn't find this issue on my first few google searches, so fixing the readme should save a lot of trouble for other fastify users