Remove unnecessary type annotations in examples #3855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed events in socket.io 4.0 remove the need for writing type annotations in callbacks of reserved events.
5 tasks
Member
|
Good catch, thanks! |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Typed events in Socket.IO 4.0 remove the need for writing type annotations in callbacks of reserved events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
socketis inferred as typeSocketas of 4.0.0; it was previously inferred asany. The type annotation is no longer needed to cast theanytoSocket.New behavior
The
Sockettype annotation can be safely removed. The behavior is unchanged, but it's less code.Other information (e.g. related issues)
Typed events in socket.io 4.0 remove the need for writing type annotations in callbacks of reserved events.