Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server supports all event emitter methods #2601

Merged
merged 1 commit into from
Nov 5, 2016
Merged

Server supports all event emitter methods #2601

merged 1 commit into from
Nov 5, 2016

Conversation

perrin4869
Copy link
Contributor

Previously, only on and emit methods were supported by Socket.IO server. This PR iterates over all EventEmitter methods and proxies them over to the main namespace.

@darrachequesne darrachequesne merged commit e9f980c into socketio:master Nov 5, 2016
@darrachequesne
Copy link
Member

Thanks a lot!

@darrachequesne darrachequesne mentioned this pull request Nov 5, 2016
Closed
@darrachequesne darrachequesne added this to the 1.6.0 milestone Nov 20, 2016
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
@perrin4869 @darrachequesne
[feature] Add support for all event emitter methods (socketio#2601)
32f4bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@perrin4869 @darrachequesne