Skip to content

removed some legency #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2017
Merged

removed some legency #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
904795a
removed json3
jimmywarting Mar 2, 2017
e37a1dc
Dropped support for 0.x
jimmywarting Mar 2, 2017
ee084cd
use native json
jimmywarting Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
language: node_js
sudo: false
node_js:
- '0.10'
- '0.12'
- '4'
- 'node'
notifications:
Expand Down
5 changes: 2 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

var debug = require('debug')('socket.io-parser');
var json = require('json3');
var Emitter = require('component-emitter');
var binary = require('./binary');
var isBuf = require('./is-buffer');
Expand Down Expand Up @@ -166,7 +165,7 @@ function encodeAsString(obj) {

// json data
if (null != obj.data) {
str += json.stringify(obj.data);
str += JSON.stringify(obj.data);
}

debug('encoded %j as %s', obj, str);
Expand Down Expand Up @@ -323,7 +322,7 @@ function decodeString(str) {

function tryParse(p, str) {
try {
p.data = json.parse(str);
p.data = JSON.parse(str);
} catch(e){
return error();
}
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
],
"dependencies": {
"debug": "2.3.3",
"json3": "3.3.2",
"component-emitter": "1.2.1",
"isarray": "0.0.1"
},
Expand Down