-
Notifications
You must be signed in to change notification settings - Fork 3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.3.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 16 files changed
- 1 contributor
Commits on Nov 16, 2021
-
Usage: ```js socket.timeout(5000).emit("my-event", (err) => { if (err) { // the server did not acknowledge the event in the given delay } }); ```
Configuration menu - View commit details
-
Copy full SHA for ccf7998 - Browse repository at this point
Copy the full SHA ccf7998View commit details -
Configuration menu - View commit details
-
Copy full SHA for d54d12c - Browse repository at this point
Copy the full SHA d54d12cView commit details -
fix: add package name in nested package.json
Note: the version must be kept in sync when publishing a new release Related: #1513
Configuration menu - View commit details
-
Copy full SHA for 53d8fca - Browse repository at this point
Copy the full SHA 53d8fcaView commit details
Commits on Nov 18, 2021
-
fix: fix
socket.disconnect().connect()
usagePreviously, calling `socket.disconnect().connect()` could, if the connection was upgraded to WebSocket, result in "disconnect" being emitted twice, and an engine being leaked. Here's what happened: > socket.disconnect() - calls `socket.destroy()` so the socket doesn't listen to the manager events anymore - then calls `manager._close()` which closes the underlying engine but not the manager itself (it waits for the "close" event of the engine) > socket.connect() - calls `socket.subEvents()` so the socket does listen to the manager events - calls `manager.open()` which creates a new engine And then the first engine emits a "close" event, which is forwarded to the socket, hence the second "disconnect" event. Related: #1014
Configuration menu - View commit details
-
Copy full SHA for 99c2cb8 - Browse repository at this point
Copy the full SHA 99c2cb8View commit details -
fix: prevent double ack with timeout
The ack was not properly removed upon timeout, and could be called twice. Related: ccf7998
Configuration menu - View commit details
-
Copy full SHA for 522ffbe - Browse repository at this point
Copy the full SHA 522ffbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e1952b - Browse repository at this point
Copy the full SHA 1e1952bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e34a3 - Browse repository at this point
Copy the full SHA 71e34a3View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.3.2...4.4.0