Fixing url encoding for connect params #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What kind of connect params cause it to mess up? Because it looks to me that the query is being escaped |
|
Nvm I see. |
yannickl
added a commit
to yannickl/socket.io-client-swift
that referenced
this pull request
May 4, 2016
|
Sorry I was out, I just added a test case to check that. The problem can occur when you pass a serialised date for example: [
"created": "2016-05-04T18:31:15+0200"
]Thank you for the merge. 👍 |
nuclearace
added a commit
that referenced
this pull request
May 4, 2016
Adding test case for issue #361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just updated my library from v4.x to v6.x and you re-introduce an issue with the connect params url encoding.
So here is my patch.
Best