fix cookies import when create the websocket#1080
fix cookies import when create the websocket#1080nuclearace merged 2 commits intosocketio:developmentfrom
Conversation
|
For more information on my use case with cookies here, I use session affinity on heroku : But I guess there are other use cases with cookies here |
|
Hm, the idea for this was to allow cookies from the initial polling connection to carry over to the websocket connection. |
|
Sure and you only want the cookies relative to the current connection/url or I miss something ? |
|
@hschouman Have you tested if this ever actually returns cookies? There's a scheme difference between |
|
You are right. In my case I have the same result with the two schemes because the cookies are stored with the base url (path == "/"). |
|
@hschouman One last thing, can you change this to be opened against development? |
|
Found this after made comment in my PR #1058 (#1058 (comment)). |
The upgrade to web socket should import only cookies relative to the url.
Without this specify, all cookies are imported and in my case it never upgrade to web socket (because there are several cookies in header that does not match the session)