Skip to content

refactor: Validate socket id before loop in addAll #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

refactor: Validate socket id before loop in addAll #64

merged 1 commit into from
Jan 2, 2021

Conversation

dantehemerson
Copy link
Contributor

Just a small refactor in addAll function, validate if socketId exists before the loop.

@darrachequesne darrachequesne merged commit 4111013 into socketio:master Jan 2, 2021
@darrachequesne
Copy link
Member

@dantehemerson good catch, thanks!

@enterstudio enterstudio mentioned this pull request Jan 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantehemerson @darrachequesne