base64id is not devDependency but dependency #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/server.js uses base64id https://github.com/socketio/engine.io/blob/0e70cf26d09ce121847ac178c0723c23316c565d/lib/server.js#L10 v1.5.4 has base64id as dependency https://github.com/socketio/engine.io/blob/6032a13cbeb45641cf0321c7fdf48d6e2ecec757/package.json#L27 socketio#350
nkzawa
added a commit
that referenced
this pull request
Sep 11, 2015
base64id is not devDependency but dependency
|
Ah, true! thanks! |
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
wait for buffer to be drained before closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/server.jsusesbase64idengine.io/lib/server.js
Line 10 in 0e70cf2
v1.5.4hasbase64idas dependencyengine.io/package.json
Line 27 in 6032a13
#350