-
Notifications
You must be signed in to change notification settings - Fork 567
Closed
Description
Note: for support questions, please use one of these channels: stackoverflow or slack
You want to:
- report a bug
- request a feature
Current behaviour
I use socket.io, therefore engine.io is one of my depended packages.
When I try to bundle my project, I have error
Module not found: Error: Can't resolve 'uws' in node_modules/engine.io/lib/server.js
(The error would not be here if I configure webpack with webpack-node-externals, but I really need all packages in a single bundle for docker container.)
Steps to reproduce (if the current behaviour is a bug)
- Add socket.io v2.2.0 to your existing project (which uses webpack) as a production dependency.
- Require it in your entry point code.
- Run webpack
Expected behaviour
It should create a bundle without errors.
Setup
- OS: centOS
- browser: server side (node.js)
- engine.io version: 3.3.2
Other information (e.g. stacktraces, related issues, suggestions how to fix)
IMO it could be fixed if engine.io declares uws as a prod dependency (not a dev dependency).
sethcwhiting and thisissami
Metadata
Metadata
Assignees
Labels
No labels