Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine.io package installation with yarn causes yarn.lock to not be created #516

Closed
1 of 2 tasks
jharris4 opened this issue Jun 26, 2017 · 4 comments
Closed
1 of 2 tasks

Comments

@jharris4
Copy link

Note: for support questions, please use one of these channels: stackoverflow or slack

You want to:

  • report a bug
  • request a feature

Current behaviour

When installing engine.io 3.1.0 with yarn, the yarn.lock file is not created despite yarn saying it was.

Steps to reproduce (if the current behaviour is a bug)

Create a package.json with the following content (only dependencies are important):

{
  "name": "yarn-lock-bug",
  "version": "1.0.0",
  "description": "repro bug with yarn not creating lock file",
  "author": "jharris4",
  "license": "MIT",
  "devDependencies": {
    "engine.io": "^3.1.0"
  }
}

then run yarn install

Expected behaviour

yarn.lock file should be properly created. Yarn says it was, but the yarn.lock file does not actually exist.

Setup

  • OS: MacOS 10.12.5
  • browser: N/A
  • engine.io version: 3.1.0

Other information (e.g. stacktraces, related issues, suggestions how to fix)

This is consistently reproducible with Node 8.x, Yarn 0.24.6 and MacOS 10.12.5.

Note that the bug only reliably happens on first install (rm -rf node_modules and rm yarn.lock)

This bug was originally filed on yarn: yarnpkg/yarn#3555

@jharris4
Copy link
Author

This seems to be specific to the use of optionalDependencies section in package.json. I've filed a new issue in the yarn repro. yarnpkg/yarn#3728

This issue can probably be closed, since it seems to be a bug in yarn. I only filed it here in case anyone else stumbles onto the same issue. :-)

@jharris4
Copy link
Author

It's actually the uws package dependency that's causing the issue. I believe it may be because the package.json is missing node-gyp as a dependency. Created an issue/PR to fix it:

https://github.com/uNetworking/bindings/issues/31

@jharris4
Copy link
Author

If/when that gets merged, I can confirm that it's fixed, and then it'd be great to update the uws version in engine.io's dependencies...

@ghost
Copy link

ghost commented Jan 8, 2018

uws is not deployed to or in any way supposed to work with Yarn. uws supports Node.js and NPM, nothing else. If you still insist on using it in environments where it is not intended to work then that's your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant