Skip to content

Bitbucket support#116

Merged
vincent-fuchs merged 34 commits intosociete-generale:masterfrom
chandrasekharpanigrahy:master
Feb 19, 2023
Merged

Bitbucket support#116
vincent-fuchs merged 34 commits intosociete-generale:masterfrom
chandrasekharpanigrahy:master

Conversation

@chandrasekharpanigrahy
Copy link
Contributor

Summary

Details

Context

Checklist:

  • I've added tests for my code.
  • Documentation has been updated accordingly to this PR

Related issue :

@chandrasekharpanigrahy
Copy link
Contributor Author

Todo - cleaning, refactoring existing test and adding few more test

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Merging #116 (6edfbbb) into master (56860a7) will decrease coverage by 4.84%.
The diff coverage is 1.28%.

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
- Coverage     42.93%   38.09%   -4.84%     
  Complexity      171      171              
============================================
  Files            61       78      +17     
  Lines          1160     1310     +150     
  Branches        120      126       +6     
============================================
+ Hits            498      499       +1     
- Misses          622      771     +149     
  Partials         40       40              
Impacted Files Coverage Δ
...ale/githubcrawler/config/BitBucketConfiguration.kt 0.00% <0.00%> (ø)
...ubcrawler/config/GitHubCrawlerAutoConfiguration.kt 0.00% <0.00%> (ø)
...tegenerale/githubcrawler/model/bitbucket/Author.kt 0.00% <0.00%> (ø)
...tegenerale/githubcrawler/model/bitbucket/Branch.kt 0.00% <0.00%> (ø)
...generale/githubcrawler/model/bitbucket/Branches.kt 0.00% <0.00%> (ø)
...etegenerale/githubcrawler/model/bitbucket/Clone.kt 0.00% <0.00%> (ø)
...tegenerale/githubcrawler/model/bitbucket/Commit.kt 0.00% <0.00%> (ø)
...egenerale/githubcrawler/model/bitbucket/Commits.kt 0.00% <0.00%> (ø)
...le/githubcrawler/model/bitbucket/DetailedCommit.kt 0.00% <0.00%> (ø)
...etegenerale/githubcrawler/model/bitbucket/Group.kt 0.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vincent-fuchs
Copy link
Contributor

thanks a lot for your contribution @chandrasekharpanigrahy ! please have a look at the 2 comments, rebase on top of master, and we'll be good to go !

-ownership and search task is not implemented yet.
# Conflicts:
#	github-crawler-autoconfigure/src/test/java/com/societegenerale/githubcrawler/BitbucketCrawlerIT.java
#	github-crawler-autoconfigure/src/test/java/com/societegenerale/githubcrawler/config/TestConfig.java
#	github-crawler-core/src/main/kotlin/com/societegenerale/githubcrawler/remote/RemoteBitBucketImpl.kt
@chandrasekharpanigrahy
Copy link
Contributor Author

Thank you for reviewing .
Fixed two comments and committed. I think Rebase was not properly done showing same commits again but there are no conflicts.

@vincent-fuchs vincent-fuchs merged commit 1cb6a14 into societe-generale:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants