Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

All dbs & exlclude option #23

Merged
merged 4 commits into from
Feb 26, 2020
Merged

All dbs & exlclude option #23

merged 4 commits into from
Feb 26, 2020

Conversation

sp-joan-madrid
Copy link
Collaborator

Added two new entry parameters to the run_job:

  • all flag (--all) select all dbs on the connection_urls.yaml
  • exclude dbs (-x) usefull when selecting all the apps but one or two

These new params are optional and work along with current commands.

Copy link
Collaborator

@philippe2803 philippe2803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool idea for a new feature.

Could you please make a small change so the list of dbs is coming from the SQLBucket object itself rather than external config?

Let's merge it right after and thanks for contributing.

@philippe2803
Copy link
Collaborator

@sp-joan-madrid check with @sp-enric-fradera on how to release to pipy. You probably need an extra commit to update the version of the library.

Feel free to merge once you're done with the versioning.

@sp-joan-madrid sp-joan-madrid merged commit a867df9 into master Feb 26, 2020
@sp-sergio-sanchez sp-sergio-sanchez deleted the feature/dbs-selector branch September 23, 2022 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants