This repository was archived by the owner on Dec 5, 2021. It is now read-only.
Closed
Conversation
Now @aarani takes over as main contributor and the possible receiver of donations, since sochix hasn't contributed in a long time.
Otherwise if there's a PR whose build is failing, it would show a red badge here (but we only care about master branch). Spotted & fix by @aarani
This pipeline doesn't come with Mono out-of-the-box like the GH-Actions one, so then we need to install mono ourselves (and there are 3 different ways to do it).
WARNING: NU5118: File 'D:\a\TLSharp\TLSharp\TLSharp.Core\bin\Debug\TLSharp.Core.dll' is not added because the package already contains file 'lib\net45\TLSharp.Core.dll' (This commit was brought from TLSharp [1] version 0.1.0.521.) [1] sochix@6b35857
Because we might use dependencies soon that require this framework. And anyway these days the .NET world is mostly a hybrid between .NETStandard/.NETCore libs and .NET4.6 ones, not older than that. (This commit was brought from TLSharp [1] version 0.1.0.522.) [1] sochix@709e5be
(This commit was brought from TLSharp [1] version 0.1.0.524.) [1] sochix@6d2c77f
Fixes sochix#857 (This commit was brought from TLSharp [1] version 0.1.0.532.) [1] sochix@c67801a
Thanks to some inspiration by this comment: sochix#474 (comment)
Fixes sochix#935 (This commit was brought from TLSharp [1] version 0.1.0.554.) [1] sochix@9a6e391
It was only meant to be used internally.
The schema is in https://core.telegram.org/schema/json so it's more logical to expect the file to be named `json`, which is what would happen if you download it with wget, for example.
Core: allow reconnecting same TelegramClient instance
It was hardcoding the Windows path separator so this could only run on Windows before.
Bear with me, the part of the code that traverses the path with ".." subfolders is actually not needed, but whatever, I had already written it.
Somehow for the previous commit hash, which had only numbers in its short version (0122072), nuget failed with: Run $date = get-date -format "yyyyMMdd-HHmm" Attempting to build package from 'TgSharp.Core.csproj'. Error NU5010: Version string specified for package reference '0.1.0-date.20200414-0908.git.0122072' is invalid. File does not exist (TgSharp.0.1.0-date.20200414-0908.git.0122072.nupkg). Now we remove the "." after "date" and "git" and use double-dash to separate initial version from the sub-version.
This makes Layer updates much easier, without having to include new files manually.
Now that we have diverged from TLSharp[1], the new pre-release versions pushed to nuget have different API and slightly different behaviour so we want them to be marked as newer. [1] since 4d09ac7
Otherwise if the hash starts with a non-number it looks weird.
It was introduced in here: 0122072
This was the result of running the latest version of the generator, which fixes many whitespace issues such as trailing whitespace.
Manual edits needed after code autogeneration.
For consistency.
These types are not auto-generated so they needed to be fixed manually.
The layer update (and namespaces/assembly/type renames) is a huge API breaking change.
Collaborator
Author
|
Ooops, wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes nblockchain#5