Skip to content

Conversation

@soburi
Copy link
Owner

@soburi soburi commented Nov 4, 2025

Summary

  • add a shared rcar_gen4_ca76.dtsi covering the Cortex-A76 common blocks
  • refactor r8a779g0.dtsi to include the new base description

Testing

  • Not run (not requested)

https://chatgpt.com/codex/tasks/task_e_69096d461b148322b3d57aec9eb4af84

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 14 to +20
cpuclusters:
- name: r52
- name: a55
- name: r8a779g0
cpuclusters:
- name: r52
- name: r8a779g0
cpuclusters:
- name: r52
- name: a76

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep r8a779g0 SoC nested under rcar_gen4 series

The new entry for the A76 cluster was added by moving r8a779g0 out of the socs: list under the rcar_gen4 series. In the current YAML the block starting with - name: r8a779g0 is aligned with the series entries (lines 17‑20), so it is now interpreted as a third series element that lacks the required socs: key. Any tooling that expects family → series → socs → cpuclusters (e.g. SoC documentation and board metadata generators) will fail to find the r8a779g0 SoC or may error when parsing this malformed structure. The r8a779g0 block should remain indented beneath rcar_gen4.socs like the original file so that both R52 and A76 clusters are described as variants of the same SoC.

Useful? React with 👍 / 👎.

@soburi soburi force-pushed the sparrowhawk-demo branch 2 times, most recently from 0396aa2 to 128bead Compare November 22, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants