Again Dev Started #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. area component updated
2. areatitle component can render area as children and no more accpeting description as a prop
with description text the ui looks too dull
sobhanbera
commented
Dec 25, 2021
sobhanbera
commented
Dec 25, 2021
| @@ -22,6 +23,7 @@ const Header = (props: HeaderProps) => { | |||
| styles.header, | |||
| { | |||
| backgroundColor: '#000000' + props.transparency || '00', | |||
| top: DEVICE_STATUSBAR_HEIGHT_CONSTANT, | |||
sobhanbera
commented
Dec 25, 2021
Comment on lines
+1
to
+24
| /** | ||
| * © 2021 Sobyte | ||
| * | ||
| * @author : Sobhan Bera (sobhanbera) | ||
| * @other_editors : | ||
| * @file : Typescript | ||
| * | ||
| * Purpose - apps dark and default theme scheme | ||
| */ | ||
|
|
||
| import ThemeColors, {RequiredCommonColors} from './ThemeProps' | ||
|
|
||
| /** | ||
| * Here different Theme could be written which should include all the following properties of @theme_interface | ||
| * and includig @common_colors_interface as the object given above @theme_interface__object + @common_colors_interface__object | ||
| */ | ||
|
|
||
| /** | ||
| * @define as much themes you want below this comment only... | ||
| * @and also give some sutaible detail of the corresponsing theme... | ||
| */ | ||
| export const LightTheme: ThemeColors = { | ||
| /** | ||
| * This is the object for Dark Theme |
There was a problem hiding this comment.
light theme added and I think I forgot about the comments to update too
sobhanbera
commented
Dec 25, 2021
| @@ -23,16 +23,20 @@ import { | |||
| GRADIENT_COLOR_SCHEME_ARRAY_MAX_LENGTH, | |||
| } from '../constants' | |||
| import {DarkTheme} from './DarkTheme' | |||
| import {LightTheme} from './LightTheme' | |||
There was a problem hiding this comment.
theme changer function added globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This development started in the settings screen specifically for theme management or provider component.