Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

add swipe helper so that you can dismiss the undo bar by swipe guesture #54

Closed
wants to merge 1 commit into from

Conversation

jtbuaa
Copy link

@jtbuaa jtbuaa commented May 19, 2015

if you do not wan't to wait 5 seconds for the undo bar dismiss itself, you can dismiss by swipe.
this swipehelper is from Android4.4.

@soarcn
Copy link
Owner

soarcn commented May 29, 2015

Hi @jtbuaa

Thanks for the PR, I just notice that google also introduce swipe to dismiss function to official snackbar. so I'd love to support this.

But your implementation introduce too many classes, which is not necessary from my view. I'd prefer keep it as simple as possible. I would suggest that using google snackbar's implementation for this. So I would close this PR now, and you are welcome to pull new request for this. Thanks

@soarcn soarcn closed this May 29, 2015
@jtbuaa
Copy link
Author

jtbuaa commented May 30, 2015

that's ok. hope you support swipe to dismiss function soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants