Allow to specify control position #4
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this control does not allow to set its position inside the map frame. This simple change allows for this behavior.
|
@tpaksu may be you create PR here? =) |
|
@soal Ok will do :) |
|
@soal sorry, I pulled @lucadegasperi 's check-in first to my repo, so my pull request contains both changes. I can undo the pull request if you want. |
vinayakkulkarni
approved these changes
Jul 18, 2019
|
Can you please merge this @soal ? |
dd
pushed a commit
to dd/vue-mapbox-geocoder
that referenced
this pull request
May 20, 2020
chore: update lockfile to include ship.js
|
@soal Hey - not sure if you're still maintaining this project, but this PR is a nice simple one and it would be really useful to get in. Could you take a look? :) |
|
Hey @shieldo, I've fixed bugs in this geocoder in |
|
Thanks @vinayakkulkarni ! |
|
@lucadegasperi @soal can we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this control does not allow to set its position inside the map frame.
This simple change allows for this behavior.