Skip to content

Conversation

@varmakarthik12
Copy link

@varmakarthik12 varmakarthik12 commented May 1, 2024

… absolute / Relative path

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

There is bug on snyk container SBOM. When the SBOM is generated on docker-archives, The scan fails with error
error while invoking depgraph workflow: could not parse container name: invalid reference format
We created a support ticket with SNyk with request ID 79368.

This PR tries to fix the said bug to allow SBOM generation on archive files with absolute / relative path.

Explain why this PR exists

ref, err := reference.Parse(imgName)
fails when image name contain file paths. This possible fix can be either sanitise the imageName or conditionally handle scan with paths (AKA archvie scans) . This PR handles this the second way.

Notes for the reviewer

I haven't tested this. Since I can't find the contribution guide or how to build or test this repo. Please feel free to contribute to this PR. Or feedback whats needed from me.

Instructions on how to run this locally, background context, what to review, questions…

@varmakarthik12 varmakarthik12 requested a review from a team as a code owner May 1, 2024 09:24
@CLAassistant
Copy link

CLAassistant commented May 1, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants